Java applet not found (problem in the official DOM testsuite)

[Koos Vriezen]

On Fri, 10 Jan 2003, Koos Vriezen wrote:

> Hmm, it generates lots of
> konqueror: WARNING: KDE detected X Error: BadMatch (invalid parameter attributes) \x08
> too.
> With the OBJECT tags it looks like there is never a request for loading an
> applet. Looks like an error in khtml.

showApplet() from rendering/render_applet.cpp:115 is never called. I don't
think kjas can know about this. If this is correct HTML, it should be
fixed elsewere.

> Without, kjas sends a sendAppletFailed command. Indeed no
> AppletStateNotification sended. Looks like a kjas error.

--- kjavaappletcontext.cpp      9 Jan 2003 13:36:48 -0000       1.34
+++ kjavaappletcontext.cpp      9 Jan 2003 23:57:58 -0000
@@ -236,6 +236,7 @@ void KJavaAppletContext::received( const
             KMessageBox::detailedError(0L, i18n("Java error while loading applet."), errorDetail);
             */
             applet->setFailed();
+            emit appletLoaded();
         }
     }
 }
@@ -244,7 +245,7 @@ bool KJavaAppletContext::appletsLoaded()
     AppletMap::const_iterator it = d->applets.begin();
     for (; it != d->applets.end(); it++) {
         if (!(*it).isNull()) {
-            if (!(*it)->isAlive()) {
+            if (!(*it)->isAlive() && !(*it)->failed()) {
                 return false;
             }
         }

fixes it.

> Koos