[PATCH] Re: CTRL+Key_Plus and CTRL+Key_Minus as zoom shortcuts in khtml

[Simon Perreault]

On December 26, 2003 15:35, Simon Perreault wrote:
> On December 24, 2003 17:46, Waldo Bastian wrote:
> > > It was discussed on fedora-devel-list at redhat.com of some integration
> > > work involving Konqueror. It was suggested that CTRL+Key_Plus and
> > > CTRL+Key_Minus be used as default zoom shortcuts in khtml. Those keys
> > > do not conflict with other shortcuts.
> >
> > This has already been implemented but for some reason the shortcuts are
> > not shown in the menu.
>
> Ok, now I understand the code correctly. khtml_part.cpp, line 318. The
> action invoked by the keyboard is not the same as the action invoked by the
> menu. This is wrong on many levels. I will try to understand why it was
> done this way, then I will code a patch that does it "the right way".

The attached patch fixes the problem. This is mostly a revert of 
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/khtml_part.cpp.diff?r1=1.823&r2=1.824&f=h 
along with a correct implementation of the intended change of 
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/khtml_part.cpp.diff?r1=1.854&r2=1.855&f=h.

Ok to commit?

-- 
Simon Perreault <nomis80 at nomis80.org> -- http://nomis80.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zoom_accel.diff
Type: text/x-diff
Size: 4745 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20031227/e0949e86/attachment.diff>