[PATCH] improved text-decoration

[Germain Garand]

Le Mardi 16 Décembre 2003 12:21, Leo Savernik a écrit :

> Did you attempt to merge WebCore's
> RenderBlock::compute{Vertical,Horizontal}PositionsForLine? I think this
> must be done, but it's too much for 3.2.

no I'm afraid not... I don't know well this part of the code and the diff is 
hudge. I simply tried to add a correct fix for a specific RenderText bug and 
even failed at that.

> > So eventually, at this point of the release cycle, would it be acceptable
> > to ressort to more hackish/temporary fixes?
>
> Do you have a working temporary fix? I only have a non working temp. fix
> ;-) Currently the main problem is that InlineFlowBoxes don't have their
> width() attribute set. Therefore, the width defaults to 0, and no
> decoration is drawn.

Well, they are sometimes drawn nevertheless

  <div>this is an <a href="" style="border: red double 20px">example</a>. 
  Now some more text.</div>

(see top left corner)

I don't have a generic fix but what I mean is: we have two incomplete code 
pathes, the new one that is unfinished, and the legacy one that has had some 
part removed in provision for the merge (e.g, in the above example, 
border/padding handling has been half removed from render_text to go in 
render_line, but in the end neither is working)

So I just ask if it's ok to concentrate on the legacy code path (e.g. by 
readding border/padding in RenderText in the above case), even if it 
conflicts with the future one...

Oh well, I talk too much, I'd better come up with actual patches ;(
Germain