Major Konqueror/KHTML regression

Fri Dec 12 23:34:02 GMT 2003

On Fri, Dec 12, 2003 at 05:48:13PM -0500, George Staikos wrote:
> On Friday 12 December 2003 07:55, Koos Vriezen wrote:
> > This is only true if started(job) is emitted (see log r 1.819). But
> > looking at David's r 1.941, could be that something similar happens for
> > you here. Maybe
> >
> > diff -u -3 -p -r1.949 khtml_part.cpp
> > --- khtml_part.cpp      12 Dec 2003 07:59:05 -0000      1.949
> > +++ khtml_part.cpp      12 Dec 2003 12:53:39 -0000
> > @@ -3889,7 +3889,10 @@ bool KHTMLPart::processObjectRequest( kh
> >    else if ( !url.isEmpty() )
> >    {
> >        //kdDebug( 6050 ) << "opening " << url.url() << " in frame " <<
> > child->m_part << endl; -      return child->m_part->openURL( url );
> > +      bool b = child->m_part->openURL( url );
> > +      if (child->m_bCompleted)
> > +          checkCompleted();
> > +      return b;
> >    }
> >    else
> >    {
> >
> > would fix it. Can you test that?
> 
>   Doesn't help.  It still kills all the parts.

That it kills the part, is because of closeURL kills the widget (see
earlier response nsplugins/plugin_part.cpp:287). But why do your pages
with flash not finish is strange. Is it already the case with a page like

<html><body>
        <embed src="http://www.tvgids.nl/images/swf/banner120x60.swf" width="120" height="60" quality=high bgcolor=#FFFFFF><br/>
</body></html>

?

Koos