[patch] fixing invalid line-height parsing

Stephan Kulow coolo at kde.org
Thu Dec 11 14:57:52 GMT 2003


Hi!

I can't say I understand the css parser fully, but the fact
that I can't find where invalid values in valueList are discarded
can either be a bug or an oversight from my side. Anyway,
attached is a test case and a fix for it.

We're currently parsing "line-height: 14 pt" as "line-height: 14"
which gives quite huge gaps between the lines ;(

What bothers me about the patch: this would affect quite some other
properties.

Greetings, Stephan

-- 
There may be no I in TEAM, but a M and an E.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20031211/d588da01/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: line-height.diff
Type: text/x-diff
Size: 828 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20031211/d588da01/attachment.diff>


More information about the kfm-devel mailing list