Patch for 67179

[Dirk Mueller]

On Monday 08 December 2003 01:33, Zack Rusin wrote:

> This one poses a lot of questions so in random order:
> 1) Yeah, it breaks string and feature freeze, I have no idea what you
> want to do about it Coolo...

I'd have a little more verbosity in the popup dialog, like

"Konqueror has the ability to store the login information in an encrypted
wallet. When the wallet is unlocked, it can then automatically restore the 
login information next time you visit this site. Do you want to store the 
information now?"


> 2) Currently it adds a questionYesNoCustom method to KMessageBox, which
> is a hacked questionYesNoCancel which lets one specify the text for the
> third button (on this dialog we do want to have "Yes", "No" and "Never
> for this site" instead of Cancel). We could avoid adding that method if

can't we reuse the YesNoCancel dialog for that?

> 3) Yes, we do have to strip the query from the url because a lot of
> sites adds time to as one of the query items and the lookup would
> obviously not work for any subsequent visits to that site.

good that you notice this bug on your own :)

> 4) Currently it uses kglobal::config to save the sites, but it could
> make sense to use one config for all apps, eg. "khtmlrc".

I think we should reuse the formcompletions thingie for that.