[PATCH] #69559

Lubos Lunak l.lunak at suse.cz
Fri Dec 5 14:17:42 GMT 2003


 Hello,

 ok, another try :). As Qt keyrelease events don't have text() set for some 
reason (possibly a bug, I'll report it), the patch solves the problem with 
two Qt autorepeat events generating only one DOM keypress events by 
postponing the first Qt keyrelease event, and it will be either entirely 
discarded or replayed depending on the following Qt autorepeat keypress. It 
looks a bit tricky, but I think the replaying doesn't affect anything.

 Also, there are no strange hack when translating Qt events to TextEventImpl, 
the event is simply left as it is, and an extra bool is added to 
NodeImpl::dispatchKeyEvent() is added to mark DOM keypress. It actually shows 
one place in RenderWidget where Qt events are translated to DOM ones 
improperly, but I haven't managed to actually find out if that code is used 
at all - I didn't reach it during testing.

 Oh, and this time I also didn't forget the reverse mapping in 
RenderWidget ;).

 The second patch has two changes where I think incorrect DOM events are used 
WRT holding a key down.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml.patch
Type: text/x-diff
Size: 10462 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20031205/ff67be7f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_usage.patch
Type: text/x-diff
Size: 1116 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20031205/ff67be7f/attachment-0001.patch>


More information about the kfm-devel mailing list