A never ending story.

[Dirk Mueller]

On Sam, 28 Sep 2002, Michael Reiher wrote:

> rendering/render_form.cpp
> - Fix for a fix by Dirk to restore the normal widget palette on the lost of
> focus. Use viewport palette instead widget class default palette(i.e.
> application palette).

Not sure why you call that a fix.. there is no guarantee that the viewport 
palette is the right palette for the widget. 

Basically, thats why I hate messing around with the palette. What was the 
purpose of your patch? make the colors configurable or to use the expected 
colorscheme for html rendering?

because the latter is much simpler to achieve. and even in a way that is 
compatible to the CSS requirements, which are pretty much broken with your 
patch. 

>  using namespace khtml;
> @@ -68,7 +71,7 @@ void RenderHtml::printBoxDecorations(QPa
>  	if( !bg )
>  	    bg = firstChild()->style()->backgroundImage();
>          if( !c.isValid() && root()->view())
> -            c = root()->view()->palette().active().color(QColorGroup::Base);
> +        c = root()->view()->viewport()->palette().active().color(QColorGroup::Base);
>      }
>  
>      int w = width();


-- 
Dirk (received 847 mails today)