Patch: Crash: blocking JS alert and deleting a window

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 29 October 2002 00:03, Koos Vriezen wrote:
> And rejecting means it will not be closed immediately? (so KHTMLView can
> post a CloseEvent next, should work I think)

I don't see why we need to reject / post later, at all.
The patch seems to work without that.
(I think that when the close event terminates, then the exit_loop happens,
and then the destructions happen, so everything's fine)

> > > Not to mention other hosts for KHTML...
> >
> > We should put the code in KParts::MainWindow::closeEvent, indeed.
> 
> Other kparts could benifit from this, great!

Unfortunately this can't be done, KParts::MainWindow doesn't know about
all the parts it hosts, only about the current one :}

But there are many things "web browser" hosts must do, for a full browser
implementation - this is just one more.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9vuob72KcVAmwbhARAjtSAJ4tifaVEiv4NqFAknNeWcSSR3d5KwCfXRyY
MN3q0ItIqveXX3jHtdPS4O0=
=Zy0C
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_mainwindow.cc.diff
Type: text/x-diff
Size: 826 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20021029/8ab803e5/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtmlview.diff
Type: text/x-diff
Size: 1141 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20021029/8ab803e5/attachment-0001.diff>