[PATCH] popups on prosieben.de

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 25 October 2002 19:16, Dirk Mueller wrote:
> Hi, 
> 
> thanks to David's help I've figured out why the popups on prosieben don't 
> work. apparently document.open(3 parameters) is supposed to call 
> window.open() in this case. 
> 
> below the patch, please review. 

I like the code factorization :) but the patch has a bug:
the wrong Window object is being used, in case someOtherWindow.document.open(...) is called.
This is equivalent to someOtherWindow.open, so we need to get hold of the window
object for the HTMLDocument, not the one "currently running the interpreter".

The attached patch does it.

(It also includes a forgotten DOMNodeList change in hasProperty as we did in tryGet.)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9udRx72KcVAmwbhARAgqyAJ9mdc+7+OSeuqPijkRtd8LGpvO4rQCgsCz2
FeuH6YzxSJiiz9NSazzF9js=
=kY+8
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: prosieben_2.diff
Type: text/x-diff
Size: 16023 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20021026/67c4b60d/attachment.diff>