Patch: Crash: blocking JS alert and deleting a window

Koos Vriezen koos.vriezen at xs4all.nl
Wed Oct 23 18:49:09 BST 2002


On Wed, 23 Oct 2002, David Faure wrote:

> On Wednesday 23 October 2002 13:50, David Faure wrote:
> > I think the only solution is to add "void done (int r)" in KDialogBase (to make
> > QDialog's method public). Patch coming up shortly.
>
> Was a bit more complex than that, to get KDialogBase to return the right value.
> I used the "escape button" instead, emulating a key event (Return) instead
> of animateClick, so that it's immediate.
>
> Patches attached for review.

Don't forget ecma/kjs_window.cpp.

Somehow I don't like it :). What if Qt decides to animate the return as
for the space bar? Wouldn't done(whatever-the-escape-does) be more
reliable in time?

Koos





More information about the kfm-devel mailing list