Patch: Crash: blocking JS alert and deleting a window

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 20 October 2002 14:59, Koos Vriezen wrote:
> Hi,
> 
> Attached the resulting patch which includes comments from David. Still not
> sure weather to use hide(), enough to make the message loop end, or
> close(), adviced by Harri but doesn't work in ecma/kjs_window, so I used
> them both :)

I found the reason for the difference between close() and hide() - while debugging 49068.

close() emits closeEvent(), which in KDialogBase (and QDialog) calls
defaultPushButton->animateClick() - which only emits clicked after a timeout,
it's not immediate.

hide() is no good either, it makes a yes/no messagebox return yes instead of no
(KDialogBase bug?)

I think the only solution is to add "void done (int r)" in KDialogBase (to make
QDialog's method public). Patch coming up shortly.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9to0c72KcVAmwbhARAufOAJ0TCf1bbxMBAsOfsnJ2qDdpj13VKACeLfH8
JqbiQTrkCRXxrANloC5F9pQ=
=zuOl
-----END PGP SIGNATURE-----