[PATCH] tables with underspecified percents and cellspacing

Lars Knoll lars at trolltech.com
Wed Oct 23 11:43:43 BST 2002


Something is still wrong with your patch. Testcase:

<div style="border: 1px solid red;">
 <table cellspacing=5>
      <tr>
        <td nowrap width="1%" valign="top" align="center" 
bgcolor="b6cbeb">#</td>

        <td nowrap bgcolor="b6cbeb">#</td> 
        <td nowrap width="7%" bgcolor="b6cbeb">#</td>
   <tr>
         <td colspan=2 bgcolor=b6cbeb>#</td>
        <td nowrap width="7%" bgcolor="b6cbeb">#</td>
    </table>
</div>

Lars

> Hi,
>
> this is a two in one:
>
> - percent tables where total sum < 100 where completely fucked.
>   see #43751, but this testcase makes it more obvious:
>
> <table>
>      <tr>
>         <td nowrap width="1%" valign="top" bgcolor="b6cbeb">#</td>
>         <td nowrap width="7%" bgcolor="b6cbeb">#</td>
>         <td nowrap width="7%" bgcolor="b6cbeb">#</td>
> </table>
>
> - table layout with cellspacing was completely broken. cellspacing
>   was taken in account for total table width, which shouldn't be the case.
>   also the width distribution was kinda screwed.
>
> testcase:
>
>     <table cellspacing=5>
>       <tr>
>         <td nowrap width="1%" valign="top" align="center"
> bgcolor="b6cbeb">#</td>
>
>         <td nowrap bgcolor="b6cbeb">#</td>
>         <td nowrap width="7%" bgcolor="b6cbeb">#</td>
>    <tr>
>          <td colspan=2 bgcolor=b6cbeb>#</td>
>         <td nowrap width="7%" bgcolor="b6cbeb">#</td>
>     </table>
>
>
> below is the patch. please review/test.





More information about the kfm-devel mailing list