[PATCH] List view renaming

John Firebaugh jfirebaugh at kde.org
Sun Oct 6 23:01:40 BST 2002


Attached patch fixes two bugs with renaming items.

http://bugs.kde.org/show_bug.cgi?id=38166
http://bugs.kde.org/show_bug.cgi?id=46501

Seems to me that a better behavior on renaming is not to actually change the 
item text until the (asynchronous) rename operation sucessfully completes.[1] 
KListView doesn't make this easy, and much as I would like to fix it there, I 
don't think it can be done in a BC way (would need to add a virtual 
slotItemRenamed). So I hacked around it in KonqBaseListViewWidget. While I 
was at it, I forbid renames to blank text to do anything, which is what MacOS 
does. The behavior before was very confusing.

-John

[1] Even better, a) don't allow renames if we detect that permissions will 
forbid it, and b) detect a rename to an already existing file and warn 
_before_ even hiding the edit box. I'll leave these as exercises for the 
reader. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: listviewrename.diff
Type: text/x-diff
Size: 2073 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20021006/ed19438d/attachment.diff>


More information about the kfm-devel mailing list