[PATCH] uiserver doesn't show progress dialog when resuming download

David Faure david at mandrakesoft.com
Tue Nov 26 19:01:29 GMT 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 26 November 2002 16:47, Waldo Bastian wrote:
> On Tuesday 26 November 2002 16:36, Waldo Bastian wrote:
> > Seems to be some unfortunate sequence of events because
> > 	m_defaultProgressVisible = defaultProgress &&
> > defaultProgress->isVisible(); resulted in false due to
> > defaultProgress->isVisible(); being false at the time
> > ProgressItem::setVisible(false) was called.
> >
> > The later ProgressItem::setVisible(true) call does not have the desired
> > effect later on then.
> >
> > Not sure if updateVisibility(); should be delayed a bit with the timer,
> > because you now get some ugly flicker when you select Cancel in the resume
> > dialog.
> 
> See this whole new&improved patch.

Looks good to me. I guess the old code was full of race conditions indeed.

Note that there's an azerty-syndrom bug in a comment -
search for qcoording :)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE948UJ72KcVAmwbhARAmAVAJ95/IiHLu7iQzpuGU2DPQ6D2vR4xwCglF5r
jjW3YMEDFhbA3rE8l/a8rzk=
=ySD7
-----END PGP SIGNATURE-----





More information about the kfm-devel mailing list