frameset.onUnload is broken

[Koos Vriezen]

On Mon, 25 Nov 2002, Koos Vriezen wrote:

> On Mon, 25 Nov 2002, Dirk Mueller wrote:
>
> > On Son, 24 Nov 2002, Koos Vriezen wrote:
> >
> > > Btw. putting a alert call in frameset.onUnload doesn't work anymore
> > > because of the modal dialog box fixes, body.onUnload does show alert.
> >
> > That would be a big bug.. :/
>
> Allowing it and KHTMLPart::begin() - KHTMLPart::clear() - d->m_doc->detach()
> would certainly cause a crash in KJS somewhere (or maybe block
> KHTMLPart::write() until KHTMLPart::begin() is finished, needs
> investigation ...).

Hmm, not true - kio thread is blocked on KHTMLPart::begin(). Probably
adding a KHTMLView::allowDialogs() and calling it before
d->m_doc->detach() would fix it.

Koos

 > >
> > PS: Please commit your patch.
>
> Thanks for doing so. Moving KDE_3_1_0_RELEASE?
>
> Koos
> >
> > --
> > Dirk (received 8 mails today)
> >
>
>