khtml's find, KFind or KComboBox

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 19 November 2002 23:18, David Faure wrote:
> On Tuesday 19 November 2002 21:05, Koos Vriezen wrote:
> > Hi,
> >
> > Wondering why,
> >  open a html page, choose a word there and enter it in the ^F box and
> >  press enter and ESC next - choose another word and do the same - press ^F
> >  and move the cursor up to the previous word and press enter,
> > it shows 'Find next occurrence of "?', I found that the pattern of KFind
> > changes to something strange (and eventually causes a crash):
> >
> > #0  KFindDialog::textSearchChanged(QString const&) (this=....
> > ...
> > #4  0x40dc139b in QComboBox::textChanged(QString const&) ()
> > ...
> > #12 0x40b93960 in QComboBox::removeItem(int) ()
> > #13 0x405fbd5c in KHistoryCombo::addToHistory(QString const&) ()
> > #14 0x417882ca in KFindDialog::slotOk()
> >
> > Maybe KFind or KComboBox should disconnect a signal before changing
> > history?
> 
> Indeed the problem is that KHistoryCombo::addToHistory() removes the
> item from where it is, and inserts it at position 0... Hmm, I guess that's on
> purpose, to make it the "most current" again, so my first attempt, fixing it
> there (which worked), is probably a bad idea.

Actually, KHistoryCombo::addToHistory() could simply call setCurrentText()
afterwards, _if_ the string that has just been added was the current text already.
What do you think, Carsten?

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE927zq72KcVAmwbhARAlr/AKCSAlOLTBvFWweS1hAwg2mJ62U51QCfTb9x
4Hm/dqRDDzs7g3Xl7h5Qg5g=
=MpUy
-----END PGP SIGNATURE-----