PATCH: khtml fix for BR# 50548
Dawit A.
adawit at kde.org
Mon Nov 11 16:38:32 GMT 2002
On Monday 11 November 2002 11:22, Harri Porten wrote:
> On Mon, 11 Nov 2002, Dawit A. wrote:
> > Hi,
> >
> > Here is a patch to address the other privacy related bug
> > reported by the same user. This is the one about the URL
> > fragment (everything after the hash mark => #) being sent
> > with the referrer header.
>
> I can't comment on the fix itself but how about rewriting the repeated 8
> lines of code to:
>
> KURL tmp = url;
> tmp.setRef(QString::null);
> d->m_referrer = tmp.url();
>
> Slightly slower but easier to read (if correct;)
I did it the way you stated above at first and changed it to its current form
for this very reason :) I did not want to do the unnecessary string
assignment (call to ::setRef) if we did not have to.
Regards,
Dawit A.
More information about the kfm-devel
mailing list