[PATCH] webdav search

Best, Jan-Pascal van j.p.vanbest at tbm.tudelft.nl
Mon May 6 08:43:55 BST 2002


Hi,
> >- The special() for SEARCH might be removed, since SEARCH can be done
> >via listDir(). What do you think?
> 
> Yep, I'd remove it, it's redundant, and not part of a released API...

Done.

> >- I've modified the signature for davStatlist() since it now has
three
> >uses, for stat, list and search. It now takes an enum argument for
> >the use method, and a QString for the search query (defaults to
null).
> 
> I would have put the detection of search metadata in davStatList 
> itself, but that's just me. There aren't going to be any cases 
> where we want to do a stat using the search method are there?
Actually, that is how I first implemented it. It look too awkward to me
that calling davStatList() with method==STATLIST_LIST, could actually
change
the method to STATLIST_SEARCH, based on the metadata. Plus, it was
necessary
for the now-removed special().

> Looks good, feel free to commit.
I can't - no CVS write access. Hamish, would you do the honor? Patch
attached.

Cheers

Jan-Pascal






-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 10193 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20020506/221cd3ff/attachment.bin>


More information about the kfm-devel mailing list