[PATCH] favicons with rel="icon"

Malte Starostik malte at kde.org
Tue Jun 25 01:05:09 BST 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Tuesday 25 June 2002 01:03 schrieb Alexander Kellett:
> On Sun, Jun 23, 2002 at 11:22:52PM +0200, Alexander Kellett wrote:
> > AFAICS, the problem is as follows, seticonforurl is called correctly, but
> > as its not a host icon, but is rather a "link" icon, the icon and its
> > related iconurl are not "related" correctly (i.e the config file doesn't
> > ever get a writeEntry for this url).
> >
> > If all such relations are called for a large host then the faviconrc
> > would get quite enormous. Therefore another less persistant but "good
> > enough" way to do fix this might be to add a cache of page urls and
> > related iconurls to the kded module itself. I'll try writing a patch now.
>
> Patch attached, together with my first patch it gets the
> mozilla.org site to work well at the very least :)
Yes, works fine except for one thing:
Go to www.mozilla.org with konq so kded knows about the icon. Now type 
"www.mozilla.org" (no quotes) into minicli: it doesn't show the icon unless 
you append a /
Attached patch in addition to yours should fix this by being tolerant wrt 
trailing slashes.
Hope it applies, your parts manually removed from `cvs diff`
- -- 
Malte Starostik
PGP: 1024D/D2F3C787 [C138 2121 FAF3 410A 1C2A  27CD 5431 7745 D2F3 C787]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9F7O4VDF3RdLzx4cRAiQlAKC6QAZ9jditOV6JCaaSRIdhx0M9mACfSFTN
jrD7Iyolj51KDZWlDTllmME=
=1mr3
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: favicons.diff
Type: text/x-diff
Size: 1224 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20020625/edc4c928/attachment.diff>


More information about the kfm-devel mailing list