Is someone working on #41620 ?

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 20 July 2002 05:37, Germain Garand wrote:
> Works perfectly ... #43393 is gone !
Good, closing.

> [....]
> It works also very well and crushes #41620 :-)
Closing too ;)

> Though to nittpick like crazy,  the:
>  
>    kdDebug(1202) << "Giving focus to new part " << m_pPart << endl;
>     m_pMainWindow->viewManager()->setActivePart( m_pPart );
> 
> statements that follows should probably be displaced into the "else" 
> (otherwise you get a "Warning! part is already active")

Ah I see (now I understand your more recent comment by private mail)
I added a
    if ( m_pMainWindow->viewManager()->activePart() != m_pPart )
around it.

> Mhhh true... but then you'd have a hard time knowing afterward if the returned 
> pointer is a new part, the same part or an invalid pointer ?
Hmm, same part would work, no?

> Konqui's implementation seems cleaner to me: separate the trading from the 
> actual creation...
Yes. I don't feel like changing KHTML though :}

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice 1.2 RC1 is slightly delayed. Stay tuned.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9QXez72KcVAmwbhARAkI7AJ4yGT5CW8Q94Qx12IxfUaBTCstTvQCfbQ13
j8vN+jiMGF8uWbeKcyOnUoY=
=zIIy
-----END PGP SIGNATURE-----