[PATCH] Widget Padding

David Faure david at mandrakesoft.com
Tue Jul 16 12:00:24 BST 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 16 July 2002 12:25, Germain Garand wrote:
> Le Mardi 16 Juillet 2002 09:46, David Faure a écrit :
> > A good example of why it's good to have new eyes look upon existing code
> > ;-) Patch looks obviously right - I also found a third occurence of this
> > error. Applied.
> >
> 
> Hello David :-)
Hi Germain ;)

> While I was there, I also encountered two similar code snippets in 
> render_applet.cpp (l.113 & 178) that look suspicious :
>  
> m_widget->resize(m_width-marginLeft()-marginRight()-paddingLeft()-paddingRight(),
>             m_height-marginTop()-marginBottom()-paddingTop()-paddingBottom());
> 
> I see no obvious reason why margins, which are normally an extrinsic property, 
> should be counted in the widget boundaries... and what about the border edge?

Unfortunately I can apply obvious typo fixes, but I can't comment about any
of the rendering code. I don't know anything about it. Dirk or Lars will comment,
though, hopefully ;) 

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is out! http://dot.kde.org/1025176121/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9M/zJ72KcVAmwbhARAra8AJ4oGZn/auwG4txILLxz+EoTtef5IwCePyyL
I0JkM91OMNcSxgZ7Cz2kxBI=
=NFzG
-----END PGP SIGNATURE-----





More information about the kfm-devel mailing list