PATCH: Open With...

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 14 July 2002 20:27, Dawit A. wrote:
> - Make sure that separators are added properly.  Currently there were 
> cuircumstances where a double/triple separators were being drawn. The
> way to make sure this does not happen is to only add separators "before"
> adding new menu items, never "after".  The culprit for the above problem were 
> the plugins, specifically the kuick plugin.  As such, with the patch attached 
> below, a plugin no longer needs to add any separator unless it specifically 
> needs to separate its own items...

I don't see the point of this change. IIRC the logic was simply the other way round:
"always add separators _after_ adding new menu items, never _before_".

The kuick plugin did it wrong - isn't it simpler to fix it?

I'm afraid you might have missed some cases, this popupmenu code (particularly
the separators) is a bit touchy (since it's used in so many different ways), and has
been fixed several times already, I'm not too happy with throwing all this away.

Since you investigated the problem - can't this be fixed with the old logic?

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is out! http://dot.kde.org/1025176121/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9MoIm72KcVAmwbhARArO0AKCdgn8AQYS9PK1j4qbPiK+n/eVCxgCdFIvQ
3Am+jzW0PUXBnbYN+TciSFY=
=NtCQ
-----END PGP SIGNATURE-----