About khtml/xml/dom2_eventsimpl.cpp revision 1.22

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 13 July 2002 12:47, you wrote:
> Hi David,
> 
> revision 1.22
> date: 2002/03/07 15:07:34;  author: faure;  state: Exp;  lines: +4 -1
> -  qKeyEvent->ignore();
> +  // Events are supposed to be accepted by default in Qt!
> +  // This line made QLineEdit's keyevents be ignored, so they were sent
> to the khtmlview
> +  // (and e.g. space would make it scroll down)
> +  //qKeyEvent->ignore();
> 
> This patch makes that the scroll keys don't work when a link has the
> focus. Shouldn't XXEdit event handles mark qKeyEvent as accepted?

Hmm, I'm no expert on the question, and I don't remember the big
picture (if I ever grasped it ;).

Anyway from the above comment: we could also state that this default 
behaviour (accepting) is correct, and that the fix would be for the link
to ignore (pass up, whatever) any keyevent it doesn't handle?

This needs more investigation, sorry I can't do it today.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is out! http://dot.kde.org/1025176121/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9MGlz72KcVAmwbhARAmYFAKCHifaqW8ognZsCY+Y817PdXyCJPQCdFgx/
bcHLBkTedTpnzZJvgSU0GxA=
=H+R5
-----END PGP SIGNATURE-----