[PATCH] Speed up iconView's setIcons 2x...

[Koos Vriezen]

On Thu, 29 Aug 2002, David Faure wrote:

> On Wednesday 28 August 2002 21:35, Koos Vriezen wrote:
> > On Wed, 28 Aug 2002, David Faure wrote:
> >
> > > Oh, ok, cool. No objections to this patch begin applied then.
> >
> > Hmmm ... is it mine or your english :)
>
> Oops, s/begin/being/

Worst typo's are those that form existing words :). It's in CVS now.

> > This timer appears to be started in 'QIconView::insertItem'.
> > So, as Lars said before in this thread, always call arrangeItemsInGrid
> > with 'false' and do an 'update()'. Maybe a call to 'sort' before 'update'
>
> Only if this means QIconView won't re-do the sorting by itself.
>
> > or call the protected 'slotUpdate' directly?
> Doesn't sound very clean, but well...

It's the only method I found doing a sorting, a repaint and stopping the
timers.

> > Maybe Qt should sort
> > icons in drawContents when new icons are added after the last paint, but
> but...?
> Anyway, this solution sounds quite good to me.

I wonder why they don't keep the icons stored in a balanced btree in the
first place.

Koos