[PATCH] Speed up iconView's setIcons 2x...

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 24 August 2002 13:50, Koos Vriezen wrote:
> Just commenting out arrangeItemsInGrid() in KonqKfmIconView::newIconSize
> already helps:
> 
> --- ./iconview/konq_iconview.cc 2002/08/21 15:42:19     1.410
> +++ ./iconview/konq_iconview.cc 2002/08/24 11:42:47
> @@ -595,7 +595,7 @@ void KonqKfmIconView::newIconSize( int s
>      m_pIconView->setIcons( size );
>      if ( m_pProps->isShowingPreview() )
>          m_pIconView->startImagePreview( m_pProps->previewSettings(), true
> );
> -    m_pIconView->arrangeItemsInGrid();
> +    //m_pIconView->arrangeItemsInGrid();
>  }

The point is that changing the icon size (after listing) should
rearrange the items so that they don't overlap each other (or have too much
space between each other).
Maybe (probably) that call must be moved, or made conditional, so that it 
only happens when _changing_ the icon size, not when loading a dir in 
the first place. Can you try changing icon sizes, to see if the patch
created a problem?

> So if this call is really necessarry for progressive loading
? No, it has nothing to do with progressive loading.

>  I would
> suggest to do this in a timer event that only does it when it's not
> completed. But I have to find a site that needs it yet.
A site?? Ah, FTP?

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-rc1 is out. ftp://ftp.kde.org/pub/kde/unstable/koffice-1.2-rc1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9ajvm72KcVAmwbhARAnaRAJ9rHkyNSdsD5KIqsrZefH0snlGZRwCfe08Y
EkTetTGnyr4ADpto6mjQvUY=
=0fy2
-----END PGP SIGNATURE-----