About KJS::HTMLCollection::getNamedItems

[Vadim Plessky]

On Thursday 15 August 2002 5:24 pm, David Faure wrote:
|  -----BEGIN PGP SIGNED MESSAGE-----
|  Hash: SHA1
|
|  On Thursday 15 August 2002 14:15, Koos Vriezen wrote:
|  > > I think this is really only for forms. The fix would be to add a new
|  > > value to the ReturnType enum in KJS::HTMLCollection, named
|  > > "ReturnForm" (i.e. only return form elements), and add support for it
|  > > in HTMLCollection, and use that value in kjs_html.cpp:169 if
|  > > element.elementId() == ID_FORM.
|  >
|  > That would be great.
|
|  Actually this was a wrong approach. Much simpler is to just use the forms
|  collection (document.forms). Same with images for consistency.

document.forms was not _forms collection_ before?  :-)
How it has been working than?

I can imagine that document (with several forms) could be parsed as DOM tree, 
but at some moment you *had* to build up forms collection...

|  This actually makes the code more sensible than it used to be, so this is
| good;)
|
|  Committed, works for me, please test the website you saw problems on.
|
|  - --
|  David FAURE, david at mandrakesoft.com, faure at kde.org

-- 

Vadim Plessky
http://kde2.newmail.ru  (English)
33 Window Decorations and 6 Widget Styles for KDE
http://kde2.newmail.ru/kde_themes.html
KDE mini-Themes
http://kde2.newmail.ru/themes/