[PATCH] Speed up iconView's setIcons 2x...
Maks Orlovich
mo002j at mail.rochester.edu
Thu Aug 15 03:17:36 BST 2002
Lars Knoll wrote:
> A few comments....
>
> The repaint in the original patch shopuld probably be an update() call.
> This posts the event (instead of triggering the paint event
> synchronously), so several calls can be merged by Qt. It usually reduces
> flicker quite a bit and should also make it faster.
Thanks for the suggestion... Koos, could you try with this change and see
whether it helps? If not, could you please describe more of your testing
setup.. I timed (clock counters) what you described, and it seems
signficantly faster with the patch... Also, Lars' suggestion gives me an
idea of how to reduce flicker: in KonqKfmIconView::newIconSize( int size )
(konqueror/iconview/knq_iconview.cc), change:
m_pIconView->arrangeItemsInGrid( ); to:
m_pIconView->arrangeItemsInGrid( FALSE );
update();
Explanation: this will often coalesce the size update and the arrangement
(note that in the circumstance I tested the iconview widget doesn't call
arrangeItemsInGrid)..
Thanks,
Maksim
More information about the kfm-devel
mailing list