[PATCH] Speed up iconView's setIcons 2x...

[Maks Orlovich]

David Faure wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Tuesday 13 August 2002 23:51, Maks Orlovich wrote:
>> > 1. dirLister->openURL, which takes 600-800ms (probably worth a look)
>> 
>> This is in fact mostly spent KonqKfmIconView::slotNewItems( const
>> KFileItemList& entries ) and suggests that my original patch is probably
>> not the best way of addressing it.. What happens here is that the
>> directory lister cache recognizes the familiar directory, and dumps all
>> of the files in it immediately to the icon view; so the view spends its
>> time processing all the items; and then updating the icons for them
>> before returning to the event loop..
> 
> Sounds correct, but I don't see where the problem is, in the above
> description.

Well, in the non-cached case the newIconSize call doesn't have much work to 
do -- it basically preps things for the new icon size,and then items start 
arriving, in the right form.. In the cached case, Konq first adds all the 
items, and then resets them...

Plus, the same delay probably doesn't look as big if it doesn't happen with 
a half-drawn toolbar..

> The original patch looked good at first sight though, I don't see why it
> slows things down in the above case.

When going to a non-cached directory it may slow things down if 
auto-arraning is not toggled by toggling a full repainted where a partial 
one would have been requested... Not sure wehter this happens this time -- 
too many cases for me to keep track of..