[PATCH] Speed up iconView's setIcons 2x...

Koos Vriezen koos.vriezen at xs4all.nl
Tue Aug 13 22:42:39 BST 2002


On Tue, 13 Aug 2002, Maks Orlovich wrote:

> Koos Vriezen wrote:
>
> > On Tue, 13 Aug 2002, Maks Orlovich wrote:
> >
> >> Thus, the speed up from the attached patch is considerable. It reduces
> >>
> >> Comments, thoughts, suggestions? Should I bug the Trolls about the above
> >> code in Qt?
> >
> > At first it looks fast, but it seems to block more. When going from a
> > large dir to another and back again, the old flikkering behaviour
> > re-appears and it blocks for a while. Small dirs, due to blocking, seems
> > to be slower with this patch.
> > (All measure done with a wet finger in the wind)
>
> Hmm, it shoud definitely be faster for large directories... What Qt version
> are you using? But small directories are a good point; if the method is
> called without being told to rearrange then for a small one repainting the
> updates one may be faster indeed... I also probably need to check whether
> repaint() is the best way to call an update here..

For large dirs, it is fast at first. Re-entering it, freezes konqi for a
second, then flikkering while displaying again. Maybe a cache thing.
Qt, just checked, only src/iconview/qiconview.cpp is not up to date,
seems to be only a doc update though.

Koos





More information about the kfm-devel mailing list