kdebase/konqueror

[Waldo Bastian]

On Thursday 25 April 2002 12:46 am, George Staikos wrote:
> On April 25, 2002 03:29, Waldo Bastian wrote:
> > kdebase/konqueror konq_mainwindow.cc,1.989,1.990 konq_view.cc,1.290,1.291
> > Author: waba
> > Thu Apr 25 09:29:58 CEST 2002
> > In directory office:/tmp/cvs-serv12867
> >
> >
> > Modified Files:
> >          konq_mainwindow.cc konq_view.cc
> > Log Message:
> > Remove horribly broken setIconURL() calls.
> > -  if (m_currentView) m_currentView->setIconURL( KURL(url) );
>
>    This change removes icons from tabs.  I assume there is a better choice
> to be made here.

Each URL has a favion associated with it, usually that favicon is based on the 
hostname only, but not necasserily. The setIconURL call takes a url that 
points to a favicon and associates that favicon with the url currently in the 
location bar.

I am sure it's nice to have icons on the tabs but that should not involve 
calling setIconURL.

Cheers,
Waldo