[Kexi] Empty Cells - Patch

Jarosław Staniek js at iidea.pl
Mon Jan 28 18:43:32 CET 2008


Sharan Rao said the following, On 2008-01-28 16:03:
> On Monday 28 Jan 2008 3:14:39 pm Jarosław Staniek wrote:
> 
>>> Index: cursor.cpp
>>> ===================================================================
>>> --- cursor.cpp	(revision 766421)
>>> +++ cursor.cpp	(working copy)
>>> @@ -406,10 +406,10 @@
>>>  					m_afterLast = true;
>>>  //js					m_at = m_records_in_buf;
>>>  					m_at = -1; //position is invalid now and will not be used
>>> -					if ((FetchResult) m_result == FetchEnd) {
>>> -						return false;
>>> -					}
>> [**]
>>
>>> -					setError(ERR_CURSOR_RECORD_FETCHING, i18n("Cannot fetch next
>>> record.")); +//					if ((FetchResult) m_result == FetchEnd) {
>>> +//						return false;
>>> +//					}
>>> +//sr					setError(ERR_CURSOR_RECORD_FETCHING, i18n("Cannot fetch next
>>> record.")); return false;
>> Do we need the above? m_error == FetchError at [**] so I guess that
>> setError() is expected.
>>
> 
> Hmm, you mean to say, I should add a 
> 
>  if( (FetchResult) m_result == FetchError ) {
>      setError( ERR_CURSOR_FETCHING, i18n("Cannot fetch next record") )  ;
>  }
> 
>  at  [**]

No, apparently you don't need to change anythung in cursor.cpp.
setError is already executed only when m_result == FetchError.

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)



More information about the Kexi mailing list