[Kexi] kexi purposefully not supporting non-file drivers?

Jarosław Staniek js at iidea.pl
Fri Dec 29 11:29:05 CET 2006


 > so.. i went to use kexi from the 1.6 branch today when i tried to create a
 > connection to a remote database it wouldn't list any of the drivers; i have
 > both mysql and postgresql installed (and ktradertest confirmed that).
 >
 > i tracked it down to a rather suspicious looking line in
 > kexidb/drivermanager.cpp .. on line 150 it checks to see if the drvType
 > == "file"; this obviously fails for db servers such as postgres. but the
 > else
 > branch on line 172 is:
 >
 > else {
 >     // no support for this driver
 >     continue;
 > }
 >
 > whoops! when i remove the continue things work fine again and i can connect to
 > my postgresql server.

Whoops, Aaron, you're fast. I introducted this bug this night, and now I am 
fixing it (remove 'continue' block, indeed).

$ svn diff -r PREV kexidb/drivermanager.cpp

Index: kexidb/drivermanager.cpp
===================================================================
--- kexidb/drivermanager.cpp    (revision 617399)
+++ kexidb/drivermanager.cpp    (working copy)
@@ -170,10 +170,8 @@
                         }
                 }
                 else {
-#ifndef KEXI_SERVER_SUPPORT
                         //no support for this driver
                         continue;
-#endif
                 }

                 m_services.insert(srv_name, ptr);

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice: http://www.kexi-project.org, http://www.koffice.org
  KDE3 & KDE4 Libraries for MS Windows: http://kdelibs.com, http://www.kde.org



More information about the Kexi mailing list