D29166: Add cached table example
jordi fita i mas
noreply at phabricator.kde.org
Fri Apr 24 23:09:49 BST 2020
jfita created this revision.
jfita added reviewers: staniek, piggz.
Herald added a project: KDb.
Herald added a subscriber: Kexi-Devel-list.
jfita requested review of this revision.
REVISION SUMMARY
It is a reimplementation of the same example from Qt: an application
that demonstrates how to use a table view to show an edit a table with
KDb, caching any changes to the data until the user explicitly submits
them. See https://doc.qt.io/qt-5/qtsql-cachedtable-example.html.
According to Jarosław, the only currently available QTableView-like
widget that has support for KDb is part of KEXI and can not be easily
reused. Moreover, KDb does not provide models based on
QAbstractItemModel. Therefore the example either had to create a table
widget or a proxy QAbstractItemModel to KDb’s cursor. I did the latter.
Qt’s example creates a SQLite database on memory (i.e., ":memory:" as
database path), but KDb does not allow that: for file-based drivers, it
checks that the driver actually created the file. Therefore i had to
create a temporary database on disk that gets deleted at exit.
The table’s sample data is the same that is being used as an example
data source for KReport.
As for the QAbstactTableModel implementation, at first i tried to use an
instance of KDbTableViewData and, like KEXI does, preload all its
records at the begining. This worked as expected.
However, i believe that i can not make use of KDbTableViewData’s edit
buffer to hold the cached data because, as i understood it, that buffer
can only hold the data for a single record —a row— while the example
wants to cache all changes to all records. I guess that
KDbTableViewData’s user case is for KEXI’s commit-on-row-change
behavior.
I made it work by keeping a map of row→KDbRecordEditBuffer inside the
model proxy, but at that point KDbTableViewData was of little benefit
and i dropped it in favor of using the cursor instead.
Finally, i had a bit of trouble with cleaning up of cursor instances.
The example’s TableModel is responsible for the cursor it creates and
therefore must delete it in its destructor. At first i deleted the
instance of TableModel inside the main window’s destructor, called when
the application exits, but it seems that KDbDriverManager registers a
slot against Qt’s aboutToQuit, a signal emitted *before* the main window
is deleted. At that point TableModel was holding a dangling cursor and
received a SIGSEGV.
Being an example i could, maybe, just ignore the deletion of that
cursor, but then i was worried that it would seem like there is no need
to close or delete cursors. That is why i now delete the table model
when the main window is closed, before the aboutToQuit signal is
emitted.
REPOSITORY
R15 KDb
BRANCH
cachedtable-example
REVISION DETAIL
https://phabricator.kde.org/D29166
AFFECTED FILES
examples/CMakeLists.txt
examples/cachedtable/CMakeLists.txt
examples/cachedtable/MessageHandler.cpp
examples/cachedtable/MessageHandler.h
examples/cachedtable/TableEditor.cpp
examples/cachedtable/TableEditor.h
examples/cachedtable/TableEditor.ui
examples/cachedtable/TableModel.cpp
examples/cachedtable/TableModel.h
examples/cachedtable/main.cpp
To: jfita, staniek, piggz
Cc: Kexi-Devel-list, barman, wicik, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20200424/874b1cfe/attachment.html>
More information about the Kexi-devel
mailing list