D25108: Fix insane delay in report items creation

Jarosław Staniek noreply at phabricator.kde.org
Fri Nov 1 18:58:41 GMT 2019


staniek created this revision.
staniek added a reviewer: piggz.
Herald added a project: KReport.
staniek requested review of this revision.

REVISION SUMMARY
  Fix insane delay in report items creation by not instantiating hi-resolution QPrinter object for each item.
  
  To be honest I am not understanding the whole word-wrapping algorithm used here.

TEST PLAN
  Approach 1: Run KEXI and create report with large number of pages. Use at
  least one text element.
  Before the fix there's noticeable O(N) delay.
  
  Approach 2: Also if we enter static value for the text item the kreportexample
  app, there is noticeable delay on each key press before this fix.
  
  Expected: all is smooth after the fix.

REPOSITORY
  R14 KReport

BRANCH
  3.2

REVISION DETAIL
  https://phabricator.kde.org/D25108

AFFECTED FILES
  src/CMakeLists.txt
  src/common/KReportUtils_p.cpp
  src/common/KReportUtils_p.h
  src/items/text/KReportItemText.cpp

To: staniek, piggz
Cc: Kexi-Devel-list, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20191101/9b8b8671/attachment.html>


More information about the Kexi-devel mailing list