D19616: Fix compilation with KIO < 5.33

Wolfgang Bauer noreply at phabricator.kde.org
Fri Mar 8 16:09:24 GMT 2019


wbauer created this revision.
wbauer added a reviewer: KEXI.
wbauer created this object with visibility "All Users".
wbauer added a project: KEXI.
Herald added a subscriber: Kexi-Devel-list.
wbauer requested review of this revision.

REVISION SUMMARY
  KURLRequester's acceptMode property has been introduced in KIO 5.33 (but Kexi's minimum supported KF5 version is 5.16.0).
  With older versions, the KUrlRequester's fileDialog() has to be modified directly.
  
  To be able to do this depending on the KIO version, set the property in the class constructor instead of the .ui file.

TEST PLAN
  Compiles fine now with KDE Frameworks 5.32 which failed before:
  
    In file included from /home/abuild/rpmbuild/BUILD/kexi-3.1.91/src/widget/KexiDBCaptionPage.h:24:0,
                     from /home/abuild/rpmbuild/BUILD/kexi-3.1.91/src/widget/KexiDBCaptionPage.cpp:20:
    /home/abuild/rpmbuild/BUILD/kexi-3.1.91/build/src/widget/ui_KexiDBCaptionPage.h: In member function 'void Ui_KexiDBCaptionPage::setupUi(QWidget*)':
    /home/abuild/rpmbuild/BUILD/kexi-3.1.91/build/src/widget/ui_KexiDBCaptionPage.h:88:25: error: 'class KUrlRequester' has no member named 'setAcceptMode'
             file_requester->setAcceptMode(QFileDialog::AcceptSave);
                             ^
  
  Still builds fine with newer versions, tested with 5.45.0 and 5.55.0.
  
  Also, the Destination file requester in the New project assistant still is in Save Mode, tested with KF 5.32.0 and 5.55.0.

REPOSITORY
  R71 Kexi

REVISION DETAIL
  https://phabricator.kde.org/D19616

AFFECTED FILES
  src/widget/KexiDBCaptionPage.cpp
  src/widget/KexiDBCaptionPage.ui

To: wbauer, #kexi
Cc: Kexi-Devel-list, barman, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20190308/ba78ed9b/attachment.html>


More information about the Kexi-devel mailing list