D12873: Fix handling ORDER BY part of queries
Jarosław Staniek
noreply at phabricator.kde.org
Mon May 14 12:16:55 UTC 2018
staniek created this revision.
staniek added a reviewer: piggz.
Restricted Application added a project: KDb.
staniek requested review of this revision.
REVISION SUMMARY
- maintain relations between connections, queries and column infos
- fix cloning queries with ORDER BY
- update and add autotests
FIXED-IN:3.2
BUG:392753
CCBUG:393705
TEST PLAN
Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views.
Expected: works, no crashes
Test 2: Try these on a standard Persons and Cars test:
select id from cars order by owner;
select id from cars order by owner, model, id;
select id, model from cars order by 2, 1;
Expected: works, no crash
REPOSITORY
R15 KDb
BRANCH
392753
REVISION DETAIL
https://phabricator.kde.org/D12873
AFFECTED FILES
autotests/CMakeLists.txt
autotests/OrderByColumnTest.cpp
autotests/OrderByColumnTest.h
src/KDbNativeStatementBuilder.cpp
src/KDbOrderByColumn.cpp
src/KDbOrderByColumn.h
src/KDbQueryColumnInfo.cpp
src/KDbQueryColumnInfo.h
src/KDbQuerySchema.cpp
src/KDbQuerySchema_p.h
To: staniek, piggz
Cc: Kexi-Devel-list, barman, wicik, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20180514/f3d75ed4/attachment.html>
More information about the Kexi-devel
mailing list