[Differential] [Commented On] D3957: Reimplement support for property groups, add API to show/hide groups

[Adam Pigg]

piggz added inline comments.

INLINE COMMENTS

> KPropertyEditorDataModel.cpp:213
>  {
> -    if (parent.isValid() && parent.column() != 0)
> +    //qDebug() << row << column << parent;
> +    if (row < 0 || column < 0 || /*!parent.isValid() ||*/ (parent.isValid() && parent.column() != 0)) {

to be left?

> KPropertyEditorDataModel.cpp:399
> +    }
> +    beginResetModel();
> +    d->groupsVisible = set;

Full reset needed?

> KPropertySet.h:235
> +     @see void changeProperty(const QByteArray &, const QVariant &) */
> +    void changePropertyIfExists(const QByteArray &property, const QVariant &value) {
> +        if (contains(property))

Add inline?

REPOSITORY
  R13 KProperty

REVISION DETAIL
  https://phabricator.kde.org/D3957

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz
Cc: Kexi-Devel-list, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20170111/4ca99227/attachment.html>