[Kexi-devel] [Differential] [Request, 647 lines] D1024: GIT_SILENT unused code--

Thu Feb 25 20:49:22 UTC 2016

staniek created this revision.
staniek added reviewers: piggz, wkosowicz, kpawlowski, wicik.
staniek added a subscriber: Kexi-Devel-list.
Herald added a project: Kexi.

REVISION SUMMARY
  Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

  This helps to know if the command object can be still accessed after the call.

  CID #1354238

  Make sure we check if success of QCache::insert is checked, the object can be deleted already if not

  CID #1354236

  Connection set's removeConnectionData no longer removed the data object.

  This removes double deletion in KexiConnectionSelectorWidget::slotRemoteAddBtnClicked() when adding connection failed.

  CID #1354237

  KexiGUIMessageHandler::showErrorMessage: avoid possible crash

  KexiFormView::storeData: avoid possible crash

  Remove useless call in KexiBlobTableEdit

  CID #1354232

  GIT_SILENT Disable dead code

  CID #1354223

  Remove dead code and fix if's

  CID #1354221

  Missing {} for "if"!

  Found as structurally dead code by CID #1354220, good!

  GIT_SILENT dead code--

  GIT_SILENT simplify code

  CID #1353848

  GIT_SILENT disable unused code, add todo

  CID #1353844

  Missing break

  CID #1353934

  Use Qt::NoModifier for modifiers, not Qt::NoButton

  Still not a big deal because both values are 0

  CID #1353936

  Table Designer: fix memory leak when not creating a new ChangeFieldPropertyCommand

  CID #1353964

  Report Designer: properly delete renderers

  CID #1353961
  CID #1353962

  Unused KUndo2Command::timedID member

  CID #1335671

  Improve direct initialization of KUndo2View internals

  CID #1335782

  KexiReportDesignView: Remove possible dereference of nullptr

  CID #1353977

  KexiItemMenu: Remove possible nullptr dereference

  CID #1353974

  GIT_SILENT warnings--

  CID #1353509

  KexiDBReportData::setSorting: Check result of appending sort field

  CID #1353507

  KexiQueryView: fix logical vs. bitwise operator - can cause issues on view switching

  Good find!
  CID #1353514

  GIT_SILENT Remove unused variables

  CID #1354193

  GIT_SILENT Remove unused memeber

  CID #1354184

  Clear status in KexiProject::items, otherwise calling it after error message will repeat the message

  Fix order of initialization in KexiActionSelectionDialog (removes crash, regression in 3.0)

  GIT_SILENT Fix signal signature in KexiActionSelectionDialog

  KexiActionSelectionDialog: Fix potential nullptr dereferences, add some constness

  CID #1354181

  KexiDBDatePicker: add missing initialization, remove unused members

  CID #1354156

  GIT_SILENT KexiDataSourcePage: Remove unused members

  CID #1354153

  Fix possible dereferences when dynamic_cast<> returns nullptr

  (from Coverity reports)

  Fix control flow issues, invalid expressions, type issues

  (from Coverity reports)

  KexiComboBoxBase: Fix integer handling (invalid index possible)

  CID #1353938, #1353939

  Check results of dynamic_cast, add missing initializations, remove unused variables

  (from Coverity reports)

REPOSITORY
  rKEXI Kexi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1024

AFFECTED FILES
  src/core/KexiView.cpp
  src/core/kexidbconnectionset.cpp
  src/core/kexidbconnectionset.h
  src/core/kexiguimsghandler.cpp
  src/core/kexiproject.cpp
  src/core/kexiprojectdata.cpp
  src/formeditor/commands.cpp
  src/formeditor/container.cpp
  src/formeditor/form.cpp
  src/formeditor/formIO.cpp
  src/formeditor/form_p.cpp
  src/formeditor/kexiactionselectiondialog.cpp
  src/formeditor/richtextdialog.cpp
  src/formeditor/widgetwithsubpropertiesinterface.cpp
  src/kexiutils/KexiFadeWidgetEffect.cpp
  src/kexiutils/KexiFadeWidgetEffect_p.h
  src/main/KexiMainWindow.cpp
  src/main/KexiMainWindow_p.cpp
  src/main/KexiMenuWidget.cpp
  src/main/KexiSearchLineEdit.cpp
  src/main/kexistatusbar.h
  src/main/startup/KexiRecentProjectsModel.cpp
  src/main/startup/KexiStartup.cpp
  src/plugins/forms/kexidatasourcepage.cpp
  src/plugins/forms/kexidatasourcepage.h
  src/plugins/forms/kexiformmanager.cpp
  src/plugins/forms/kexiformscrollview.cpp
  src/plugins/forms/kexiformview.cpp
  src/plugins/forms/widgets/kexidbautofield.cpp
  src/plugins/forms/widgets/kexidbdatepicker.cpp
  src/plugins/forms/widgets/kexidbdatepicker.h
  src/plugins/forms/widgets/kexidbform.cpp
  src/plugins/forms/widgets/kexidblineedit.cpp
  src/plugins/forms/widgets/kexidbutils.cpp
  src/plugins/importexport/csv/kexicsvimportdialog.cpp
  src/plugins/importexport/csv/kexicsvwidgets.cpp
  src/plugins/queries/kexiquerydesignerguieditor.cpp
  src/plugins/queries/kexiqueryview.cpp
  src/plugins/reports/kexidbreportdata.cpp
  src/plugins/reports/kexireportdesignview.cpp
  src/plugins/reports/kexireportdesignview.h
  src/plugins/reports/kexireportview.cpp
  src/plugins/tables/kexitabledesignerview.cpp
  src/plugins/tables/kexitabledesignerview_p.cpp
  src/widget/KexiConnectionSelectorWidget.cpp
  src/widget/dataviewcommon/kexidataawareobjectiface.cpp
  src/widget/dataviewcommon/kexidataprovider.cpp
  src/widget/dataviewcommon/kexiformdataiteminterface.cpp
  src/widget/kexiqueryparameters.cpp
  src/widget/kexislider.cpp
  src/widget/navigator/KexiProjectNavigator.cpp
  src/widget/navigator/KexiProjectNavigator.h
  src/widget/tableview/KexiDataTableView.cpp
  src/widget/tableview/KexiTableScrollArea.cpp
  src/widget/tableview/KexiTableScrollAreaHeader.cpp
  src/widget/tableview/KexiTableScrollArea_p.h
  src/widget/tableview/kexiblobtableedit.cpp
  src/widget/tableview/kexicomboboxbase.cpp
  src/widget/tableview/kexicomboboxpopup.cpp
  src/widget/tableview/kexicomboboxtableedit.cpp
  src/widget/tableview/kexitableedit.cpp
  src/widget/undo/kundo2stack.cpp
  src/widget/undo/kundo2stack.h
  src/widget/undo/kundo2view.cpp
  src/widget/utils/kexidropdownbutton.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, wkosowicz, kpawlowski, wicik
Cc: Kexi-Devel-list, staniek