[Kexi-devel] [Differential] [Request, 38 lines] D1001: Table designer: Improve warning box about losing data when table schema should be altered

[staniek (Jarosław Staniek)]

staniek created this revision.
staniek added reviewers: piggz, wkosowicz, kpawlowski, wicik.
staniek added a subscriber: Kexi-Devel-list.
Herald added a project: Kexi.

REVISION SUMMARY
  There's the "Saving changes for existing table design is now required.
  Do you want to save the design now?
  
  Warning! Any data in this table will be removed upon design's saving!"
  
  Improvements:
  
  - better button texts, "Save" and "Discard" were apparently not enough for some users, see e.g. https://forum.kde.org/viewtopic.php?f=220&t=131143&p=351981#p351973
  - Fix the issue with displaying HTML tags due to joining parts of messages, now we're using KLocalizedString more for lazy evaluation

TEST PLAN
  Create a test table with at least 1 record, add/remove one column from the design, switch to the data view. Observe the message.

REPOSITORY
  rKEXI Kexi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1001

AFFECTED FILES
  src/plugins/tables/kexitabledesignerview.cpp
  src/plugins/tables/kexitabledesignerview_p.cpp
  src/plugins/tables/kexitabledesignerview_p.h
  src/plugins/tables/kexitablepart.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, wkosowicz, kpawlowski, wicik
Cc: Kexi-Devel-list, staniek