Sticky toolviews

[Milian Wolff]

On Saturday 14 June 2014 19:45:33 Milian Wolff wrote:
> On Monday 02 June 2014 11:07:27 Milian Wolff wrote:
> > On Monday 02 June 2014 01:16:58 Aleix Pol wrote:
> > > On Sat, May 31, 2014 at 4:52 PM, Milian Wolff <mail at milianw.de> wrote:
> > > >  On Friday 30 May 2014 19:06:20 Aleix Pol wrote:
> > > > > On Fri, May 30, 2014 at 4:02 PM, Sven Brauch
> > > > > <svenbrauch at googlemail.com>
> > > > > 
> > > > > wrote:
> > > > > > On Friday 30 May 2014 12:16:02 Aleksey Midenkov wrote:
> > > > > > > Is it possible to 'stick' toolviews? F.ex. to have both Projects
> > > > > > > and
> > > > > > > 
> > > > > > > Filesystem open on left side one below the other. Thanks!
> > > > > > 
> > > > > > Not really, I think there was a half-working related feature once
> > > > > > but
> > > > > > I
> > > > > > 
> > > > > > don't
> > > > > > 
> > > > > > think it currently works.
> > > > > 
> > > > > It used to show different toolviews at the same time when pressing
> > > > 
> > > > control,
> > > > 
> > > > > but I can't do that anymore... so I guess not. :/
> > > > 
> > > > That's odd - it should work. Hm I wonder what broke this. I doubt it
> > > > was
> > > > intentionally disabled, no?
> > > > 
> > > > 
> > > > 
> > > > Bye
> > > 
> > > I don't remember, adding dymo on CC because he might remember. Maybe it
> > > prevented something else from working?
> > > 
> > > I've been grep'ing for CTRL/ALT/SHIFT uses and I couldn't find it.
> > 
> > Git log showed me this:
> > 
> > commit 275345c1fe64b8262259f236f78a0cdf17ed053c
> > Author: Aleix Pol <aleixpol at kde.org>
> > Date:   Thu Apr 4 16:37:00 2013 +0200
> > 
> >     Simplify grouping behavior regarding the control key modifier
> >     
> >     Only check if control is pressed when showing the dock using the
> >     button,
> > 
> > otherwise it leads to weird behaviors. (see bug)
> > 
> >     BUG: 296475
> > 
> > That at least gives us a hint at where the code is and how it tests it all
> > (via. Qt::ControlModifier). So someone should investigate and debug this,
> > to find out why and when it stopped working :)
> 
> Hah, this feature was deliberately disabled and noone worked on it:

OK, only the restoration is deliberately disabled. The rest was broken due to 
unintuitive recursion happening. I've now fixed this in master. Please test 
it!
-- 
Milian Wolff
mail at milianw.de
http://milianw.de