new kdevelop sessions runner for review

Pino Toscano pino at kde.org
Mon Mar 21 13:16:37 GMT 2011


Hi,

Alle lunedì 21 marzo 2011, Sebastian Kügler ha scritto:
> I've just committed a branch of kdeplasma-addons containing a new
> runner plugin. It reads kdevelop sessions and makes them available
> via their name to krunner. You just pull up krunner, enter your
> session name, and start it.

Shouldn't this be shipped aside kdevelop, instead of kdeplasma-addons?
I see various reasons for this:
a) a normal user has no use for it
b) even a developer would not have much to do with it if not installing 
kdevelop (hence kdevelop could just ship it)
c) it manually parses the kdevelop session files and watches for their 
changes, so if in the future kdevelop changes its storage of sessions, 
this runner would break (while having it shipped with kdevelop would 
allow it to be always up-to-date with it, independently from the KDE SC 
version)

Aside from those, I've left some review in RB.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop/attachments/20110321/5e6502f2/attachment.sig>


More information about the KDevelop mailing list