<table><tr><td style="">rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7995" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">I care, otherwise I wouldn't review. Simplify the code, then we can run the benchmark and see what it brings.</pre></div></blockquote>
<p>I already know what the benchmark brings, and what's more, I know what my implementation brings in actual KDevelop sessions (the good and the bad).</p>
<p>I have tried to explain several times why I think the ProjectWatcher class is justified and why I don't want to use KDirWatch directly. We'll see what feedback I get on my question about the underlying main reason but as long as I'm not convinced KDW::addDir() can be called directly we'll remain in the current stalemate.</p>
<p>Simplifying? I've been doing the opposite since I gave up on upstreaming. I've been adding the simple measures against multiple concurrent reloads I posted elsewhere (too much hassle to maintain that as a separate patch). And a way to opt out and use the old dirwatching mechanism which does perform better for certain kinds of projects even if they take longer to load. That doesn't really make the patch more more complicated of course, and it should make benchmarking old vs. new more trivial (no more rebuilding with or without the patch).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7995" rel="noreferrer">https://phabricator.kde.org/D7995</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, mwolff<br /><strong>Cc: </strong>aaronpuchert, arrowdodger, kfunk, dfaure, mwolff, brauch, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight<br /></div>