D27933: Don't compile and link twice tokenizer.cpp

Johnny Jazeix noreply at phabricator.kde.org
Sun Mar 8 15:59:41 GMT 2020


jjazeix created this revision.
jjazeix added a reviewer: KDevelop.
jjazeix added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
jjazeix requested review of this revision.

REVISION SUMMARY
  Try to fix https://build.kde.org/view/Failing/job/KDevelop/job/kdev-css/job/kf5-qt5%20WindowsMSVCQt5.14/
  
  kdev4cssparser.lib(kdev4cssparser.dll) : error LNK2005: "public: __cdecl Css::Tokenizer::Tokenizer(class KDevPG::TokenStream *,class QString const &)" (??0Tokenizer at Css@@QEAA at PEAVTokenStream@KDevPG@@AEBVQString@@@Z) already defined in tokenizer.cpp.obj
  
  tokenizer.cpp is both in the target kdev4cssparser and css-parser. It should be only on one.

TEST PLAN
  I couldn't compile due to missing dependencies, neither on Linux or Windows so no test done :/
  But looking at the issue, it should fix it.

REPOSITORY
  R56 KDevelop CSS

REVISION DETAIL
  https://phabricator.kde.org/D27933

AFFECTED FILES
  parser/CMakeLists.txt

To: jjazeix, #kdevelop
Cc: kdevelop-devel, develoot, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20200308/1bdc7f61/attachment.html>


More information about the KDevelop-devel mailing list