TLC for the cmakemanager - feedback required

Aleix Pol aleixpol at kde.org
Wed Feb 19 17:31:52 GMT 2020


I've been running it for the last couple of days and, despite
massively hitting QTBUG-82351 all over the place, it's working
seemingly well.

I'll go through the code later but I'd say we are on the safe side anyway.

Aleix

On Tue, Feb 18, 2020 at 9:03 PM Milian Wolff <mail at milianw.de> wrote:
>
> On Mittwoch, 12. Februar 2020 23:11:01 CET Milian Wolff wrote:
> > On Sonntag, 9. Februar 2020 22:41:25 CET Milian Wolff wrote:
> > > Hey all,
> > >
> > > I finally found some time to give the cmake manager plugin some tender
> > > loving care. I removed a bunch of dead code, fixed some unit tests and
> > > added support for the cmake-file-api [1].
> > >
> > > You can find my work over at [2]. Be warned: I may potentially force push
> > > to that branch. That said, I would really welcome if others could have a
> > > look and give me some feedback.
> > >
> > > My preliminary testing shows that it seems to work. The one big feature
> > > that's missing is watching the cmake files for changes and then
> > > automatically triggering a reconfiguration to update the code model data.
> > > I'll give that a shot in the next days and also test it on some bigger
> > > applications at work, before creating a merge request.
> > >
> > > Cheers
> > >
> > > [1]: https://bugs.kde.org/show_bug.cgi?id=417202
> > > [2]: https://invent.kde.org/mwolff/kdevelop/commits/cmake-file-api
> >
> > The important features, namely code-model support and even project reloading
> > when a cmake file is edited, is now implemented. I've created a merge
> > request:
> >
> > https://invent.kde.org/kde/kdevelop/merge_requests/106
> >
> > There's even a nice new feature, namely target grouping by the FOLDER target
> > property. This way, all the pesty CTest targets get automatically grouped.
> > And it's all generic and users can create custom groups, if desired :)
> >
> > Please test and give feedback, esp. on non-trivial CMake projects! If I
> > don't hear anything back, I'll merge this sometime next week.
>
> Anyone? Otherwise my plan is to merge this tomorrow morning.
>
> Cheers
>
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de


More information about the KDevelop-devel mailing list