D26254: Add support for PHP 7.4's typed properties

Hugues Mitonneau noreply at phabricator.kde.org
Thu Apr 9 16:18:27 BST 2020


hmitonneau added a comment.


  Sorry for the very late comment...
  Before this commit, the type of properties were deduced from the assign default value:
  F8227231: Screenshot_20200409_170757.png <https://phabricator.kde.org/F8227231>
  Since this commit, the type is `<no type>` if it is not explicitly specified (either in php7 style or in doc-comment)
  F8227233: Screenshot_20200409_170648.png <https://phabricator.kde.org/F8227233>
  
  Some tests do not pass anymore.
  
  Do you think this new behavior is correct or not ?
  I can fix the tests if you think the new behavior is OK.

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D26254

To: pprkut
Cc: hmitonneau, kdevelop-devel, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20200409/dddb0529/attachment.html>


More information about the KDevelop-devel mailing list