D5447: Only add auto-detected compilers to model if they actually exist
noreply at phabricator.kde.org
Fri Sep 20 05:13:26 BST 2019
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
sorry for the super long delay. I like what I'm seeing - if this works, please commit
> arrowd wrote in compilerprovider.cpp:264
> In other comment you said
> > afaik it's called path since it can be a user-provided absolute path.
> So, if `compiler->path()` can return absolute path, is it OK to pass it as is into `rt->findExecutable()`?
Yes, an absolute path will then just be resolved directly within the RT without looking at the PATH env var of the RT
To: arrowd, mwolff, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel