D23834: Add template for Kirigami application development with cmake

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:11
> +# where to look first for cmake modules, before ${CMAKE_ROOT}/Modules/ is checked
> +set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
> +

${ECM_KDE_MODULE_DIR} is part of ${ECM_MODULE_PATH} already, so remove.

> CMakeLists.txt:18
> +include(ECMPoQmTools)
> +include(KDECompilerSettings NO_POLICY_SCOPE)
> +

Best includes these three macros before the others, in this order:

  ​include(KDEInstallDirs)
  include(KDECMakeSettings)
  include(KDECompilerSettings NO_POLICY_SCOPE)

as there purpose is to influence everything else.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D23834

To: dkardarakos, apol
Cc: kossebau, jbbgameich, kdevelop-devel, hmitonneau, christiant, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, glebaccon, mkraemer, cahfofpai, asghaier, domson, antismap, iodelay, tbalzer, dkardarakos, PureTryOut, lnj, neofytosk, alexeymin, geetamc, IlyaBizyaev, Pilzschaf, akshaydeo, dvasin, surgenight, jessep, Sergobot, arrowd, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190910/6fb63c85/attachment-0001.html>