D5447: Only add auto-detected compilers to model if they actually exist
noreply at phabricator.kde.org
Tue May 7 16:12:37 BST 2019
arrowd added inline comments.
> mwolff wrote in compilerprovider.cpp:264
> remove the `QFileInfo` and `.fileName()` here, just use the path like previously. note how the path could be an absolute path not inside the PATH, your patch would break this
In other comment you said
> afaik it's called path since it can be a user-provided absolute path.
So, if `compiler->path()` can return absolute path, is it OK to pass it as is into `rt->findExecutable()`?
To: arrowd, mwolff, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel