D5447: Only add auto-detected compilers to model if they actually exist
Gleb Popov
noreply at phabricator.kde.org
Mon May 6 19:26:26 BST 2019
arrowd added inline comments.
INLINE COMMENTS
> mwolff wrote in compilerfactories.cpp:51
> afaik it's called path since it can be a user-provided absolute path. But the builtin compiler defaults all want to do dynamic lookups. so no, I think it's fine to keep the API but again - don't hardcode an absolute path in the host here - it should be a name that's checked in either the runtime or the host
So, this hunk and other `ditto`s should be completely reversed?
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D5447
To: arrowd, mwolff, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190506/1e0029b4/attachment.html>
More information about the KDevelop-devel
mailing list